The console draws a tab instead of dropping it
consoleDraw gave meanings to newline, carriage return and backspace and dropped every other byte below the first glyph. A tab was one of those, so it left no mark on the screen at all - while the same byte went down the serial line, where a host terminal laid it out perfectly. That is why a tab separated file read correctly and displayed wrongly. Type and More were never at fault: they hand the file's bytes to the console unchanged, and the console is where the tabs stopped. An assembler symbol table came out with its fields run together. A tab now moves the cursor to the next stop, eight columns apart, and wraps when the next stop would reach or pass the last column - which is what an ordinary character does at the edge, rather than a rule only tabs obey. It MOVES rather than writing spaces, the way a terminal does: a carriage return followed by a tab steps over what is on the line and leaves it. Kept in the console rather than expanded by Type, More, and every future program that prints text. Three checks in video.sh, each of which fails on a different mistake: a tab renders the same screen as the spaces it stands for, one that runs off the edge renders the same screen as a newline, and sixteen letters tabbed across still have their ink - which is the one that fails if a tab is implemented by writing spaces. Verified with break.sh both ways. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2JrLzFvuFX9fgi1LDRjrW
This commit is contained in:
co-authored by
Claude Opus 5
parent
7dca141aae
commit
019c93a587
+132
@@ -3117,6 +3117,138 @@ else
|
||||
result no "a fault puts the screen back where text can be seen" "no picture was written"
|
||||
fi
|
||||
|
||||
# ---- A tab moves the cursor to the next stop ----
|
||||
#
|
||||
# The console gave newline, carriage return and backspace meanings and dropped every other
|
||||
# byte below the first glyph, so a tab left no mark on the screen at all - while the same
|
||||
# byte went down the serial line, where a host terminal laid it out. A tab separated file
|
||||
# read perfectly and displayed as its fields run together, which is exactly what Type and
|
||||
# More did to an assembler symbol table.
|
||||
#
|
||||
# CHECKED AS A PICTURE AGAINST THE SPACES IT STANDS FOR, rather than by reading a cell. If a
|
||||
# tab from column one reaches column eight, then "A" tab "B" and "A" seven spaces "B" put the
|
||||
# same glyphs in the same cells and leave the cursor in the same place, so the two screens are
|
||||
# the same bytes. That tests where the cursor landed without this suite having to learn how a
|
||||
# glyph is stored.
|
||||
run tabstop <<'ASM'
|
||||
#Program
|
||||
start:
|
||||
INIA 0x41 ; 'A'
|
||||
OUTA 0x00
|
||||
INIA 0x09 ; Tab, which should reach column eight.
|
||||
OUTA 0x00
|
||||
INIA 0x42 ; 'B'
|
||||
OUTA 0x00
|
||||
HALT
|
||||
ASM
|
||||
run tabspaces <<'ASM'
|
||||
#Program
|
||||
start:
|
||||
INIA 0x41 ; 'A'
|
||||
OUTA 0x00
|
||||
INIB 0d7 ; The seven spaces that get to the same place.
|
||||
spaces:
|
||||
INIA 0x20
|
||||
OUTA 0x00
|
||||
DECB
|
||||
BNB spaces
|
||||
INIA 0x42 ; 'B'
|
||||
OUTA 0x00
|
||||
HALT
|
||||
ASM
|
||||
if cmp -s "$BUILD/tabstop.ppm" "$BUILD/tabspaces.ppm"; then
|
||||
result ok "a tab reaches the next stop" "the same screen as the spaces it stands for"
|
||||
else
|
||||
result no "a tab reaches the next stop" "the screen differs from the same line spaced out"
|
||||
fi
|
||||
|
||||
# ---- And a tab that would leave the screen wraps, the way a character does ----
|
||||
#
|
||||
# The screen is forty columns and the stops are eight apart, so from column thirty three the
|
||||
# next stop is forty, which is off the end. An ordinary character at the edge wraps, and a
|
||||
# tab that stopped in the last column instead would be inventing a rule only tabs obey.
|
||||
run tabwrap <<'ASM'
|
||||
#Program
|
||||
start:
|
||||
INIB 0d33 ; Columns nought to thirty two, so the cursor is at thirty three.
|
||||
fill:
|
||||
INIA 0x41
|
||||
OUTA 0x00
|
||||
DECB
|
||||
BNB fill
|
||||
INIA 0x09 ; The next stop is forty, which is the edge.
|
||||
OUTA 0x00
|
||||
INIA 0x42
|
||||
OUTA 0x00
|
||||
HALT
|
||||
ASM
|
||||
run tabwrapped <<'ASM'
|
||||
#Program
|
||||
start:
|
||||
INIB 0d33
|
||||
fill:
|
||||
INIA 0x41
|
||||
OUTA 0x00
|
||||
DECB
|
||||
BNB fill
|
||||
INIA 0x0A ; A new line, which is where the tab should have gone.
|
||||
OUTA 0x00
|
||||
INIA 0x42
|
||||
OUTA 0x00
|
||||
HALT
|
||||
ASM
|
||||
if cmp -s "$BUILD/tabwrap.ppm" "$BUILD/tabwrapped.ppm"; then
|
||||
result ok "and one that runs off the edge wraps" "the same screen as a new line"
|
||||
else
|
||||
result no "and one that runs off the edge wraps" "it did not go to the next row"
|
||||
fi
|
||||
|
||||
# ---- A tab does not rub out what it passes over ----
|
||||
#
|
||||
# The other way to make a tab visible is to write spaces to the next stop, and it is wrong
|
||||
# for the reason a terminal does not do it: a cursor moved back to the start of a line and
|
||||
# tabbed forward would erase the line it moved over. This writes a row, returns to the front
|
||||
# of it, and tabs.
|
||||
run tabkeeps <<'ASM'
|
||||
#Program
|
||||
start:
|
||||
INIB 0d16
|
||||
fill:
|
||||
INIA 0x41 ; Sixteen letters.
|
||||
OUTA 0x00
|
||||
DECB
|
||||
BNB fill
|
||||
INIA 0x0D ; Back to the front of the line, without leaving it.
|
||||
OUTA 0x00
|
||||
INIA 0x09 ; And a tab across the letters already there.
|
||||
OUTA 0x00
|
||||
INIA 0x42 ; Which lands in column eight, on top of one of them.
|
||||
OUTA 0x00
|
||||
HALT
|
||||
ASM
|
||||
LETTERS="$(python3 - "$BUILD/tabkeeps.ppm" <<'PY2'
|
||||
import sys
|
||||
data = open(sys.argv[1], "rb").read()
|
||||
fields = data.split(b"\n", 3)
|
||||
width, height = (int(n) for n in fields[1].split())
|
||||
body = fields[3]
|
||||
# The first row of cells is eight pixels tall. A cell that still holds a letter has ink in
|
||||
# it; one a tab blanked has none. Counting ink across the row says how many survived.
|
||||
ink = 0
|
||||
for cell in range(16):
|
||||
lit = False
|
||||
for y in range(8):
|
||||
for x in range(cell * 8, cell * 8 + 8):
|
||||
at = (y * width + x) * 3
|
||||
if body[at:at + 3] != body[0:3]:
|
||||
lit = True
|
||||
if lit:
|
||||
ink += 1
|
||||
print(ink)
|
||||
PY2
|
||||
)"
|
||||
[ "$LETTERS" = "16" ] && result ok "and does not rub out what it moves over" "all sixteen letters are still there" || result no "and does not rub out what it moves over" "$LETTERS of sixteen cells still have ink"
|
||||
|
||||
echo
|
||||
if [ "$FAIL" -eq 0 ]; then
|
||||
echo "All $PASS video checks passed."
|
||||
|
||||
Reference in New Issue
Block a user